Skip to content

Align code for MavenSession top/root directory with Maven 4 - #11953

Merged
slawekjaranowski merged 1 commit into
apache:maven-3.10.xfrom
slawekjaranowski:session-top-root-dir
Apr 20, 2026
Merged

Align code for MavenSession top/root directory with Maven 4#11953
slawekjaranowski merged 1 commit into
apache:maven-3.10.xfrom
slawekjaranowski:session-top-root-dir

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member

In Maven 4 we have the same classes as compatability for Maven 3.

New implementation in 3.x should be the same as we have in 4.x


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

In Maven 4 we have the same classes as compatability for Maven 3.

New implementation in 3.x should be the same as we have in 4.x
@slawekjaranowski

Copy link
Copy Markdown
Member Author

@slawekjaranowski slawekjaranowski self-assigned this Apr 20, 2026
@slawekjaranowski slawekjaranowski added the skip-changelog Skip this PR from automatically changelog generation label Apr 20, 2026
@slawekjaranowski

Copy link
Copy Markdown
Member Author

skip changelog as continuation

@slawekjaranowski
slawekjaranowski merged commit 874428e into apache:maven-3.10.x Apr 20, 2026
22 checks passed
@slawekjaranowski
slawekjaranowski deleted the session-top-root-dir branch April 20, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants